ableegoldman commented on code in PR #12859:
URL: https://github.com/apache/kafka/pull/12859#discussion_r1027007003
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/ProcessorParameters.java:
##########
@@ -114,13 +114,12 @@ KTableSource<KIn, VIn> kTableSourceSupplier() {
@SuppressWarnings("unchecked")
<KR, VR> KTableProcessorSupplier<KIn, VIn, KR, VR>
kTableProcessorSupplier() {
- // This cast always works because KTableProcessorSupplier hasn't been
converted yet.
Review Comment:
What happens if/when we call this and it returns `null`? Is that pretty much
guaranteed to be a bug/result in an NPE, or are there valid uses for returning
null? Sorry, wasn't keeping up with these changes so just trying to wrap my
head around it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
