satishd commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1032870562
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1804,7 +1860,9 @@ object UnifiedLog extends Logging {
lastShutdownClean: Boolean = true,
topicId: Option[Uuid],
keepPartitionMetadataFile: Boolean,
- numRemainingSegments: ConcurrentMap[String, Int] = new
ConcurrentHashMap[String, Int]): UnifiedLog = {
+ numRemainingSegments: ConcurrentMap[String, Int] = new
ConcurrentHashMap[String, Int],
+ remoteStorageSystemEnable: Boolean = false,
Review Comment:
This is the existing convention used in other properties like
unclean.leader.election.enable etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
