hachikuji commented on code in PR #12885:
URL: https://github.com/apache/kafka/pull/12885#discussion_r1035394196
##########
core/src/main/scala/kafka/server/ControllerApis.scala:
##########
@@ -400,7 +407,8 @@ class ControllerApis(val requestChannel: RequestChannel,
if (!authorizedTopicNames.contains(name)) {
response.topics().add(new CreatableTopicResult().
setName(name).
- setErrorCode(TOPIC_AUTHORIZATION_FAILED.code))
+ setErrorCode(TOPIC_AUTHORIZATION_FAILED.code).
+ setErrorMessage("Authorization failed."))
Review Comment:
Ok. I thought we left the error message empty whenever the message did not
have additional detail over the default message in `Errors`. I think it would
be fine to remove the message in both cases as well. I'll leave it up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
