hachikuji commented on code in PR #12847: URL: https://github.com/apache/kafka/pull/12847#discussion_r1037728116
########## core/src/main/scala/kafka/server/RequestHandlerHelper.scala: ########## @@ -107,6 +107,18 @@ class RequestHandlerHelper( // Throttle the channel if the request quota is enabled but has been violated. Regardless of throttling, send the // response immediately. + def sendResponse( Review Comment: How about `sendMaybeThrottle` or `sendAndMaybeThrottle`? I think including "Response" is redundant given the parameters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
