ijuma commented on code in PR #12343:
URL: https://github.com/apache/kafka/pull/12343#discussion_r1039680283
##########
clients/src/test/java/org/apache/kafka/common/utils/JavaTest.java:
##########
@@ -46,9 +49,22 @@ public void testIsIBMJdk() {
assertTrue(Java.isIbmJdk());
}
+ @Test
+ public void testIsIBMJdkSemeru() {
+ System.setProperty("java.vendor", "Oracle Corporation");
+ assertFalse(Java.isIbmJdkSemeru());
+ System.setProperty("java.vendor", "IBM Corporation");
+ System.setProperty("java.runtime.name", "Java(TM) SE Runtime
Environment");
+ assertFalse(Java.isIbmJdkSemeru());
+ System.setProperty("java.vendor", "IBM Corporation");
+ System.setProperty("java.runtime.name", "IBM Semeru Runtime Certified
Edition");
+ assertTrue(Java.isIbmJdkSemeru());
Review Comment:
Looks like we don't clear the set property, won't that pollute the rest of
the test suite that runs in that jvm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
