ableegoldman commented on PR #12955: URL: https://github.com/apache/kafka/pull/12955#issuecomment-1340276915
> This change may be scope-creep for this PR, and maybe better handled as a lateral refactor after the release blocker bug is resolved. Just my 2 cents as the 3.4 release manager -- unless this refactor helps to stabilize the actual feature as-is or fixes a suspected issue, please save this for a followup PR and avoid increasing the scope here: both to reduce the possibility of introducing new bugs with a nontrivial last-minute refactor, and of course to help ensure this fix is merged in a timely manner. Happy to discuss further especially since I have absolutely zero context on the particular issue or this part of the codebase in general, but just keep in mind how close we are to the end of the 3.4 release. Thanks 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
