cmccabe commented on PR #12932: URL: https://github.com/apache/kafka/pull/12932#issuecomment-1341277577
Thanks for this, @dajac . Can you add a test that the `Invalid default for struct field` message appears as expected when the default is set to something other than `null`? `MessageDataGeneratorTest.java` has some examples of tests like that The other test that I really want is a test that a tagged nullable struct will be correctly ignored by code prior to this PR. Unfortunately I don't have a good suggestion for how to do that in junit or ducktape. Can you do some kind of manual test to ensure that this is the case? (Once we have people using tagged nullable structs the ducktape cross-version compatibility tests will serve as a de-facto test of this, but that will come later) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
