jolshan commented on code in PR #12968:
URL: https://github.com/apache/kafka/pull/12968#discussion_r1044712173
##########
core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala:
##########
@@ -167,7 +167,7 @@ class RPCProducerIdManager(brokerId: Int,
if (nextProducerId > currentProducerIdBlock.lastProducerId) {
val block = nextProducerIdBlock.poll(maxWaitMs, TimeUnit.MILLISECONDS)
if (block == null) {
- throw Errors.REQUEST_TIMED_OUT.exception("Timed out waiting for next
producer ID block")
Review Comment:
This poll specifically seems pretty unexpected to me since we typically
either timeout or get the pid block. To hit this specific case, I think the
poll itself has to fail which to me is unexpected. Whether the onTimeout error
is expected is a different question though.
I'm not sure I understand what handling it lower would look like. Are you
thinking just building in the response and not going to KafkaApis? (Also I
still need to confirm it actually goes to kafka apis)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
