cmccabe commented on code in PR #12983:
URL: https://github.com/apache/kafka/pull/12983#discussion_r1047785762
##########
core/src/main/scala/kafka/server/metadata/BrokerServerMetrics.scala:
##########
@@ -17,17 +17,48 @@
package kafka.server.metadata
-import java.util.concurrent.atomic.AtomicLong
+import kafka.metrics.KafkaMetricsGroup
+
+import java.util.concurrent.atomic.{AtomicLong, AtomicReference}
import org.apache.kafka.common.MetricName
import org.apache.kafka.common.metrics.Gauge
import org.apache.kafka.common.metrics.Metrics
import org.apache.kafka.common.metrics.MetricConfig
+import org.apache.kafka.image.MetadataProvenance
+import org.apache.kafka.image.loader.MetadataLoaderMetrics
+import org.apache.kafka.server.metrics.KafkaYammerMetrics
+
+import java.util.concurrent.TimeUnit.NANOSECONDS
-final class BrokerServerMetrics private (metrics: Metrics) extends
AutoCloseable {
+final class BrokerServerMetrics private (
+ metrics: Metrics
+) extends MetadataLoaderMetrics with KafkaMetricsGroup {
Review Comment:
I think this should be included here because `MetadataLoader` needs to
publish its metrics. It's a pretty small change in general -- just means
`BrokerMetadataListener` needs to call into `BrokerServerMetrics` rather than
directly bumping a metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
