[ 
https://issues.apache.org/jira/browse/KAFKA-14405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646869#comment-17646869
 ] 

RockieRockie edited comment on KAFKA-14405 at 12/14/22 12:32 AM:
-----------------------------------------------------------------

Hello :)

Do you basically mean that the StreamConfig should always log a warning in the 
constructor that its not mutable through the parameter passed in constructor?

ex. Properties props = new Properties();
props.put(StreamsConfig.APPLICATION_ID_CONFIG, "original");
//builders etc.
KafkaStreams streams = new KafkaStreams(builder.build(), props); //During 
execution of this statement log a warning.
 
props.put(StreamsConfig.APPLICATION_ID_CONFIG, "replacement"); //Here the 
change won't be reflected in the streams.applicationConfigs


was (Author: JIRAUSER289157):
Hello :)

Do you basically mean that the StreamConfig should always log a warning in the 
constructor that its not mutable through the parameter passed in constructor?

ex. Properties props = new Properties();
props.put(StreamsConfig.APPLICATION_ID_CONFIG, "original");
//builders etc.
KafkaStreams streams = new KafkaStreams(builder.build(), props);
 
props.put(StreamsConfig.APPLICATION_ID_CONFIG, "replacement"); //Here the 
change won't be reflected in the streams.applicationConfigs

> Log a warning when users attempt to set a config controlled by Streams
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-14405
>                 URL: https://issues.apache.org/jira/browse/KAFKA-14405
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: A. Sophie Blee-Goldman
>            Assignee: Ashmeet Lamba
>            Priority: Major
>              Labels: newbie
>
> Related to https://issues.apache.org/jira/browse/KAFKA-14404
> It's too easy for users to try overriding one of the client configs that 
> Streams hardcodes, and since we just silently ignore it there's no good way 
> for them to tell their config is not being used. Sometimes this may be 
> harmless but in cases like the Producer's partitioner, there could be 
> important application logic that's never being invoked.
> When processing user configs in StreamsConfig, we should check for all these 
> configs and log a warning when any of them have been set



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to