ashmeet13 opened a new pull request, #12988: URL: https://github.com/apache/kafka/pull/12988
Streams hard-codes a few configurations, currently the documentation refers to 5 such configs. The four mentioned within - [Parameters controlled by Kafka Streams](https://kafka.apache.org/documentation/streams/developer-guide/config-streams.html#parameters-controlled-by-kafka-streams) + [enable.auto.commit](https://kafka.apache.org/documentation/streams/developer-guide/config-streams.html#enable-auto-commit). Three out of the 4 mentioned within the [Parameters controlled by Kafka Streams](https://kafka.apache.org/documentation/streams/developer-guide/config-streams.html#parameters-controlled-by-kafka-streams) are also present within [Default Values](https://kafka.apache.org/documentation/streams/developer-guide/config-streams.html#default-values). This PR makes changes to warn the user when a configuration set by them is being overridden. Due to the overlapping documentation I have gone through the code and have separated the configs in a few categories - - Non configurable _consumer_ configs when EOS is **disabled** - ``` enable.auto.commit allow.auto.create.topics ``` - Non configurable _consumer_ configs when EOS is **enabled** - ``` isolation.level ``` - Non configurable _producer_ configs when EOS is **enabled** - ``` enable.idempotence max.in.flight.requests.per.connection transactional.id ``` - Default _consumer_ configs which can be configured - ``` auto.offset.reset max.poll.records ``` - Default producer configs which can be configured - ``` linger.ms ``` `StreamsConfig` already had code to log warnings when a non-configurable property was being set. It was missing logging warnings when `allow.auto.create.topics` was configured. I have added this change and refactored the code a bit. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
