dajac commented on code in PR #12982:
URL: https://github.com/apache/kafka/pull/12982#discussion_r1048243221
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -1323,6 +1323,17 @@ class ReplicaManagerTest {
replicaManager.becomeLeaderOrFollower(2, leaderAndIsrRequest, (_, _) =>
())
+ appendRecords(replicaManager, tp0,
TestUtils.singletonRecords(s"message".getBytes)).onFire { response =>
+ assertEquals(Errors.NONE, response.error)
+ }
+ // fetch as follower to advance the high watermark
Review Comment:
nit: Should we say `Fetch as follower to initialise the log end offset of
the replica`? Because this is what we need in the condition that you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
