cmccabe commented on code in PR #13001:
URL: https://github.com/apache/kafka/pull/13001#discussion_r1050263485
##########
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala:
##########
@@ -290,29 +295,27 @@ case class BrokerToControllerQueueItem(
)
class BrokerToControllerRequestThread(
+ initialNetworkClient: KafkaClient,
+ var isNetworkClientForZkController: Boolean,
networkClientFactory: ControllerInformation => KafkaClient,
metadataUpdater: ManualMetadataUpdater,
controllerNodeProvider: ControllerNodeProvider,
config: KafkaConfig,
time: Time,
threadName: String,
retryTimeoutMs: Long
-) extends InterBrokerSendThread(threadName, null, Math.min(Int.MaxValue,
Math.min(config.controllerSocketTimeoutMs, retryTimeoutMs)).toInt, time,
isInterruptible = false) {
-
- var isZkController = false
- private def maybeResetNetworkClient(controllerInformation:
ControllerInformation,
- initialize: Boolean = false): Unit = {
- if (initialize || isZkController != controllerInformation.isZkController) {
- if (!initialize) {
- debug("Controller changed to " + (if (isZkController) "zk" else
"kraft") + " mode. " +
- "Resetting network client")
- }
+) extends InterBrokerSendThread(threadName, initialNetworkClient,
Math.min(Int.MaxValue, Math.min(config.controllerSocketTimeoutMs,
retryTimeoutMs)).toInt, time, isInterruptible = false) {
Review Comment:
can we put each of these on one line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
