ijuma commented on code in PR #13016:
URL: https://github.com/apache/kafka/pull/13016#discussion_r1052279836
##########
tools/src/test/java/org/apache/kafka/tools/MetadataQuorumCommandTest.java:
##########
@@ -53,12 +53,12 @@ public MetadataQuorumCommandTest(ClusterInstance cluster) {
* 3. Fewer brokers than controllers
*/
@ClusterTests({
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 3, controllers =
3),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 3, controllers = 3),
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 3, controllers =
2),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 3, controllers = 2),
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 2, controllers =
3),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 2, controllers = 3)
+ @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 1, controllers =
1),
+ @ClusterTest(clusterType = Type.KRAFT, brokers = 1, controllers = 1),
Review Comment:
The test name indicates it's testing replication, that doesn't happen if
there's a single broker & controller, right?
##########
tools/src/test/java/org/apache/kafka/tools/MetadataQuorumCommandTest.java:
##########
@@ -53,12 +53,12 @@ public MetadataQuorumCommandTest(ClusterInstance cluster) {
* 3. Fewer brokers than controllers
*/
@ClusterTests({
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 3, controllers =
3),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 3, controllers = 3),
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 3, controllers =
2),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 3, controllers = 2),
- @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 2, controllers =
3),
- @ClusterTest(clusterType = Type.KRAFT, brokers = 2, controllers = 3)
+ @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 1, controllers =
1),
+ @ClusterTest(clusterType = Type.KRAFT, brokers = 1, controllers = 1),
Review Comment:
The test name indicates its testing replication, that doesn't happen if
there's a single broker & controller, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
