cadonna commented on code in PR #13025:
URL: https://github.com/apache/kafka/pull/13025#discussion_r1053549663
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -276,6 +276,11 @@ private void addTask(final Task task) {
changelogReader.transitToUpdateStandby();
}
}
+
+ // Move task to paused tasks immediately to not make any
progress
+ if (topologyMetadata.isPaused(task.id().topologyName())) {
+ pauseTask(task);
Review Comment:
Why not have this `if` on line 264 and adding it to the `pausedTasks` right
away instead of calling `pauseTask()` which does a couple of steps like writing
a checkpoint which is not needed at when the task is just added to the state
updater?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]