dajac commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054494916
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1397,77 +1397,172 @@ class KafkaApis(val requestChannel: RequestChannel,
requestHelper.sendResponseMaybeThrottle(request, createResponse)
}
- private def handleOffsetFetchRequestBetweenV1AndV7(request:
RequestChannel.Request): Unit = {
- val header = request.header
+ private def handleOffsetFetchRequestBetweenV1AndV7(request:
RequestChannel.Request): CompletableFuture[Unit] = {
Review Comment:
I am not sure. We had a lot of complex logic before. I have tried to
simplify as much as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
