jolshan commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1054880470
##########
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java:
##########
@@ -227,6 +227,24 @@ public boolean requireStable() {
return data.requireStable();
}
+ public List<OffsetFetchRequestData.OffsetFetchRequestGroup> groups() {
+ if (version() >= 8) {
+ return data.groups();
+ } else {
+ OffsetFetchRequestData.OffsetFetchRequestGroup group =
+ new
OffsetFetchRequestData.OffsetFetchRequestGroup().setGroupId(data.groupId());
+
+ data.topics().forEach(topic -> {
Review Comment:
I feel like the streams + collection to list is extraneous and I'm not sure
it's much more intuitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
