akhileshchg commented on code in PR #13028:
URL: https://github.com/apache/kafka/pull/13028#discussion_r1054933363
##########
metadata/src/main/java/org/apache/kafka/image/ClusterImage.java:
##########
@@ -34,9 +34,15 @@ public final class ClusterImage {
public static final ClusterImage EMPTY = new
ClusterImage(Collections.emptyMap());
private final Map<Integer, BrokerRegistration> brokers;
+ private final Map<Integer, BrokerRegistration> zkBrokers;
public ClusterImage(Map<Integer, BrokerRegistration> brokers) {
this.brokers = Collections.unmodifiableMap(brokers);
+ this.zkBrokers = Collections.unmodifiableMap(brokers
Review Comment:
I thought about this. Have to not strong preference since methods based on
zkBrokers should not be called often. Will change.
##########
core/src/main/scala/kafka/controller/ControllerChannelManager.scala:
##########
@@ -359,13 +400,15 @@ abstract class
AbstractControllerBrokerRequestBatch(config: KafkaConfig,
throw new IllegalStateException("Controller to broker state change
requests batch is not empty while creating a " +
s"new one. Some UpdateMetadata state changes to brokers
$updateMetadataRequestBrokerSet with partition info " +
s"$updateMetadataRequestPartitionInfoMap might be lost ")
+ metadataInstance = metadataProvider()
Review Comment:
Yes.
##########
metadata/src/main/java/org/apache/kafka/image/MetadataDelta.java:
##########
@@ -206,6 +206,9 @@ public void replay(ApiMessage record) {
* updating the highest offset and epoch.
*/
break;
+ case ZK_MIGRATION_STATE_RECORD:
+ // TODO handle this
+ break;
Review Comment:
Spill over. Will temove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
