divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057615287
########## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ########## @@ -150,6 +150,10 @@ import static org.junit.jupiter.api.Assertions.assertTrue; import static org.junit.jupiter.api.Assertions.fail; +/** + * Note to future authors in this class. If you close the consumer, close with DURATION.ZERO to reduce the duration of the + * test. Review Comment: > can be combined into the previous line as we don't have the hard limit on number of char per line :) I would prefer to keep the line width limited to 120 chars. Helps to fit in one screen width. In majority of the Kafka code base, we stick to this 120 char width wrapping. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
