[GitHub] [kafka] kirktrue commented on a diff in pull request #12813: KAFKA-14317: ProduceRequest timeouts are logged as network exceptions

[GitBox]

kirktrue commented on code in PR #12813:
URL: https://github.com/apache/kafka/pull/12813#discussion_r1057895364


##########
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##########
@@ -1284,6 +1292,11 @@ public ClientResponse disconnected(long timeMs, 
AuthenticationException authenti
                     true, null, authenticationException, null);
         }
 
+        public ClientResponse timedOut(long timeMs, AuthenticationException 
authenticationException) {
+            return new ClientResponse(header, callback, destination, 
createdTimeMs, timeMs,
+                    true, true, null, authenticationException, null);

Review Comment:
   Correct. I have added a check in the `ClientResponse` constructor to ensure 
that time outs are only set when also disconnected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org