jolshan commented on code in PR #13037:
URL: https://github.com/apache/kafka/pull/13037#discussion_r1057950277
##########
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##########
@@ -441,6 +441,17 @@ object TestUtils extends Logging {
replicaAssignment.size
}
+ def isTopicExistsAndHasSameNumPartitionsAndReplicationFactor(cause:
Throwable): Boolean = {
+ // return true when:
+ // (1) the cause of exception is `TopicExistsException`
+ // (2) all partitions metadata are propagated
+ // (3) topic has the expected partitions number and replication factor
Review Comment:
I agree that the comments are restating the code, but one thing that may be
useful to note (not clear from the method name) is that we are waiting for the
partition metadata now in this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
