ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1062119225
########## storage/src/main/java/org/apache/kafka/server/log/internals/LeaderEpochCheckpoint.java: ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.log.internals; + +import java.util.List; + +public interface LeaderEpochCheckpoint { Review Comment: I originally also preferred having `server` in the package name, but on further thought, there are advantages in basically having the module name as the package name after `kafka`. It avoids accidental split packages across modules, which can cause problems if we ever decide to use Java 9 modules. If we agree on that approach, then the module names would be `org.apache.kafka.storage.internals.checkpoint` and `org.apache.kafka.storage.internals.log` (one annoying aspect of using `log` is that GitHub filters it from their code navigation, but we probably have to live with that for now). @junrao what are your thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
