jolshan commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063012777
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
when(cache.getAliveBrokerNodes(any[ListenerName])).thenReturn(aliveBrokers)
}
+ @Test
+ def testMaybeAddLogDirFetchersForV1MessageFormat(): Unit = {
Review Comment:
You mentioned that the v2 format wasn't as easy to replicate. Is it too hard
to have a test for? Or are the cases similar enough for v1 to cover both and v1
is less flaky?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
