[GitHub] [kafka] hachikuji commented on a diff in pull request #13104: KAFKA-14612: Make sure to write ConfigRecords to metadata log iff topic is created

[GitBox]

hachikuji commented on code in PR #13104:
URL: https://github.com/apache/kafka/pull/13104#discussion_r1066409782


##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -725,6 +725,8 @@ private ApiError createTopic(CreatableTopic topic,
         records.add(new ApiMessageAndVersion(new TopicRecord().
             setName(topic.name()).
             setTopicId(topicId), (short) 0));
+        // ConfigRecords go after TopicRecord but before PartitionRecord(s).
+        records.addAll(configResult.records());

Review Comment:
   This looks a little suspicious. Don't we need to pull only the respective 
configs for the topic that is being created? We should have a test case with 
multiple topics.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org