[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

[GitBox]

divijvaidya commented on code in PR #13096:
URL: https://github.com/apache/kafka/pull/13096#discussion_r1067120704


##########
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##########
@@ -761,10 +761,7 @@ class KRaftClusterTest {
     image: ClusterImage,
     brokerId: Int
   ): Boolean = {
-    Option(image.brokers().get(brokerId)) match {
-      case None => false
-      case Some(registration) => !registration.fenced()
-    }
+    Option(image.brokers().get(brokerId)).exists(registration => 
!registration.fenced())

Review Comment:
   understood, I had not realized that we don't run with `inline-scala` by 
default. In that case, is the recommendation to never use `Option.exists` in 
Kafka code base or is your concern about object allocations specific to 
performance sensitive code path only?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org