jolshan commented on code in PR #12901:
URL: https://github.com/apache/kafka/pull/12901#discussion_r1067528730
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala:
##########
@@ -608,4 +610,77 @@ class GroupCoordinatorAdapterTest {
future.get().asScala.toList.sortWith(_.name > _.name)
)
}
+
+ @Test
+ def testCommitTransactionalOffsets(): Unit = {
+ val groupCoordinator = mock(classOf[GroupCoordinator])
+ val time = new MockTime()
+ val adapter = new GroupCoordinatorAdapter(groupCoordinator, time)
+ val now = time.milliseconds()
+
+ val ctx = makeContext(ApiKeys.TXN_OFFSET_COMMIT,
ApiKeys.TXN_OFFSET_COMMIT.latestVersion)
+ val data = new TxnOffsetCommitRequestData()
+ .setGroupId("group")
+ .setMemberId("member")
+ .setGenerationId(10)
+ .setProducerEpoch(1)
+ .setProducerId(2)
+ .setTransactionalId("transaction-id")
+ .setTopics(List(
+ new TxnOffsetCommitRequestData.TxnOffsetCommitRequestTopic()
+ .setName("foo")
+ .setPartitions(List(
+ new TxnOffsetCommitRequestData.TxnOffsetCommitRequestPartition()
+ .setPartitionIndex(0)
+ .setCommittedOffset(100)
+ .setCommittedLeaderEpoch(1)
+ ).asJava)
+ ).asJava)
+ val bufferSupplier = BufferSupplier.create()
+
+ val future = adapter.commitTransactionalOffsets(ctx, data, bufferSupplier)
+ assertFalse(future.isDone)
+
+ val capturedCallback: ArgumentCaptor[Map[TopicPartition, Errors] => Unit] =
+ ArgumentCaptor.forClass(classOf[Map[TopicPartition, Errors] => Unit])
+
+ verify(groupCoordinator).handleTxnCommitOffsets(
+ ArgumentMatchers.eq(data.groupId),
+ ArgumentMatchers.eq(data.producerId),
+ ArgumentMatchers.eq(data.producerEpoch),
+ ArgumentMatchers.eq(data.memberId),
+ ArgumentMatchers.eq(None),
+ ArgumentMatchers.eq(data.generationId),
+ ArgumentMatchers.eq(Map(
+ new TopicPartition("foo", 0) -> new OffsetAndMetadata(
+ offset = 100,
+ leaderEpoch = Optional.of[Integer](1),
+ metadata = "",
+ commitTimestamp = now,
+ expireTimestamp = None
+ )
+ )),
+ capturedCallback.capture(),
+ ArgumentMatchers.eq(RequestLocal(bufferSupplier))
+ )
+
+ capturedCallback.getValue.apply(Map(
+ new TopicPartition("foo", 0) -> Errors.NONE
+ ))
+
+ val expectedData = new TxnOffsetCommitResponseData()
+ .setTopics(List(
+ new TxnOffsetCommitResponseData.TxnOffsetCommitResponseTopic()
+ .setName("foo")
+ .setPartitions(List(
+ new TxnOffsetCommitResponseData.TxnOffsetCommitResponsePartition()
+ .setPartitionIndex(0)
+ .setErrorCode(Errors.NONE.code)
+ ).asJava)
+ ).asJava
+ )
Review Comment:
nit: during the merge I think this parenthesis got moved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
