jolshan commented on code in PR #12902:
URL: https://github.com/apache/kafka/pull/12902#discussion_r1070186244
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##########
@@ -470,4 +470,45 @@ class GroupCoordinatorAdapter(
expireTimestamp = expireTimestamp
)
}
+
+ override def deleteOffsets(
+ context: RequestContext,
+ request: OffsetDeleteRequestData,
+ bufferSupplier: BufferSupplier
+ ): CompletableFuture[OffsetDeleteResponseData] = {
+ val future = new CompletableFuture[OffsetDeleteResponseData]()
+
+ val partitions = mutable.ArrayBuffer[TopicPartition]()
+ request.topics.forEach { topic =>
+ topic.partitions.forEach { partition =>
+ partitions += new TopicPartition(topic.name, partition.partitionIndex)
+ }
+ }
+
+ val (groupError, topicPartitionResults) = coordinator.handleDeleteOffsets(
+ request.groupId,
+ partitions,
+ RequestLocal(bufferSupplier)
+ )
+
+ if (groupError != Errors.NONE) {
+ future.completeExceptionally(groupError.exception)
+ } else {
+ val response = new OffsetDeleteResponseData()
+ topicPartitionResults.forKeyValue { (topicPartition, error) =>
+ var topic = response.topics.find(topicPartition.topic)
Review Comment:
It was part of the protocol from the start. It basically means that when we
deserialize, it builds a collection where the elements can be looked up via
hashing. That's how we can use "find" here. (Not a new change, but I haven't
seen it used often.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
