dajac commented on code in PR #12902:
URL: https://github.com/apache/kafka/pull/12902#discussion_r1070933822
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -2764,37 +2763,170 @@ class KafkaApisTest {
val request = buildRequest(offsetDeleteRequest)
val requestLocal = RequestLocal.withThreadConfinedCaching
-
when(clientRequestQuotaManager.maybeRecordAndGetThrottleTimeMs(any[RequestChannel.Request](),
- any[Long])).thenReturn(0)
- when(groupCoordinator.handleDeleteOffsets(
- ArgumentMatchers.eq(group),
- ArgumentMatchers.eq(Seq(
- new TopicPartition("topic-1", 0),
- new TopicPartition("topic-1", 1),
- new TopicPartition("topic-2", 0),
- new TopicPartition("topic-2", 1)
- )),
- ArgumentMatchers.eq(requestLocal)
- )).thenReturn((Errors.NONE, Map(
- new TopicPartition("topic-1", 0) -> Errors.NONE,
- new TopicPartition("topic-1", 1) -> Errors.NONE,
- new TopicPartition("topic-2", 0) -> Errors.NONE,
- new TopicPartition("topic-2", 1) -> Errors.NONE,
- )))
+ val future = new CompletableFuture[OffsetDeleteResponseData]()
+ when(newGroupCoordinator.deleteOffsets(
+ request.context,
+ offsetDeleteRequest.data,
+ requestLocal.bufferSupplier
+ )).thenReturn(future)
createKafkaApis().handleOffsetDeleteRequest(request, requestLocal)
+ val offsetDeleteResponseData = new OffsetDeleteResponseData()
+ .setTopics(new
OffsetDeleteResponseData.OffsetDeleteResponseTopicCollection(List(
+ new OffsetDeleteResponseData.OffsetDeleteResponseTopic()
+ .setName("topic-1")
Review Comment:
good catch. fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
