jolshan commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1386149959
> Has anyone checked that we always acquire a lock when we call methods like activeProducers and isEmpty? I wonder if this class has thread safety bugs. @ijuma I actually did take a peak when working on KIP-890 and other producer ID fun. There is a lock on every usage of active producers (except its usage in a log message). As for isEmpty, there are two usages (one in UnifiedLog -- to rebuild the log and one in LogLoader) and neither is protected via lock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
