jolshan commented on code in PR #13107:
URL: https://github.com/apache/kafka/pull/13107#discussion_r1072895900
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -390,7 +390,7 @@ class ReplicaManager(val config: KafkaConfig,
// epoch, a sentinel value (NoEpoch) is used and bypass the
epoch validation.
if (requestLeaderEpoch == LeaderAndIsr.EpochDuringDelete ||
requestLeaderEpoch == LeaderAndIsr.NoEpoch ||
- requestLeaderEpoch > currentLeaderEpoch) {
+ requestLeaderEpoch >= currentLeaderEpoch) {
Review Comment:
Just curious -- was the epoch check put in place because we were concerned
about stale stop replicas? Just trying to figure out why we need it and the
implications for adding the current epoch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
