divijvaidya commented on code in PR #13111:
URL: https://github.com/apache/kafka/pull/13111#discussion_r1073623221
##########
core/src/main/scala/kafka/controller/KafkaController.scala:
##########
@@ -1698,7 +1708,7 @@ class KafkaController(val config: KafkaConfig,
private def processPartitionModifications(topic: String): Unit = {
def restorePartitionReplicaAssignment(
topic: String,
- newPartitionReplicaAssignment: Map[TopicPartition, ReplicaAssignment]
+ newPartitionReplicaAssignment: Set[(TopicPartition, ReplicaAssignment)]
Review Comment:
we changed the call to Zk from `zkClient.getFullReplicaAssignmentForTopics`
to `zkClient.getReplicaAssignmentAndTopicIdForTopics` since the former dud not
provide the topic Id. As a result of this change we needed to use `flatMap` at
line 1730 and hence it results in a `Set`.
We can work on improving the readibility as you suggested once we have a
consensus on whether we even want to make this change at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
