jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080662718
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##########
@@ -215,4 +223,86 @@ CompletableFuture<OffsetDeleteResponseData> deleteOffsets(
OffsetDeleteRequestData request,
BufferSupplier bufferSupplier
);
+
+ /**
+ * Return the partition index for the given Group.
+ *
+ * @param groupId The group id.
+ *
+ * @return The partition index.
+ */
+ int partitionFor(String groupId);
+
+ /**
+ * Commit or abort the pending transactional offsets for the given
partitions.
+ *
+ * @param producerId The producer id.
+ * @param partitions The partitions.
+ * @param transactionResult The result of the transaction.
+ */
+ void onTransactionCompleted(
+ long producerId,
+ Iterable<TopicPartition> partitions,
+ TransactionResult transactionResult
+ );
+
+ /**
+ * Delete the provided partitions' offsets.
Review Comment:
Is it clearer to say "Remove the provided deleted partitions offsets"?
I guess the parameter explains that it was deleted partitions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
