[ https://issues.apache.org/jira/browse/KAFKA-6474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419175#comment-16419175 ]
Filipe Agapito commented on KAFKA-6474: --------------------------------------- Hi John. I hope you are also doing well. Thanks for the warning! Since fixing this issue requires changing a lot of files I've been rebasing frequently to keep conflicts to a minimum, so I already have your commit. Nice to see that it passed all checks and that it is all working fine. By the way, I've already migrated a lot of tests from KStreamTestDriver and ProcessorTopoogyTestDriver to TopologyTestDriver (about 40 classes so far). Should I open a pull request, marked as [WIP], to start getting some feedback, or is it preferable to wait until I finish the refactor (I'm missing about 10 classes) before opening the PR? > Rewrite test to use new public TopologyTestDriver > ------------------------------------------------- > > Key: KAFKA-6474 > URL: https://issues.apache.org/jira/browse/KAFKA-6474 > Project: Kafka > Issue Type: Improvement > Components: streams, unit tests > Affects Versions: 1.1.0 > Reporter: Matthias J. Sax > Assignee: Filipe Agapito > Priority: Major > Labels: beginner, newbie > > With KIP-247 we added public TopologyTestDriver. We should rewrite out own > test to use this new test driver and remove the two classes > ProcessorTopoogyTestDriver and KStreamTestDriver. -- This message was sent by Atlassian JIRA (v7.6.3#76005)