C0urante commented on PR #13148:
URL: https://github.com/apache/kafka/pull/13148#issuecomment-1408822680

   @mimaison Yeah, that's correct. I'm hoping that the `verify` calls for 
`plugins::withClassLoader` will be sufficient for now. I've also added a small 
comment explaining why we perform that check, which hopefully makes this part a 
little clearer and harder to break with future changes.
   
   We could file a follow-up ticket to add true integration or system tests for 
isolated classpath loading that set up plugins off of the system classpath and 
test various APIs that interact with them (such as the `GET 
/connector-plugins/<type>/config` endpoint), but I'm on the fence as to whether 
that'd be worth the bloat in CI build time and testing logic. LMKWYT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to