cmccabe commented on code in PR #13176:
URL: https://github.com/apache/kafka/pull/13176#discussion_r1093550518
##########
core/src/main/scala/kafka/migration/MigrationPropagator.scala:
##########
@@ -79,6 +81,18 @@ class MigrationPropagator(
_image = image
}
+ /**
+ * A very expensive function that creates a map with an entry for every
partition that exists, from
+ * (topic name, partition index) to partition registration.
+ */
+ def materializePartitions(topicsImage: TopicsImage):
util.Map[TopicPartition, PartitionRegistration] = {
Review Comment:
Using mutable Scala maps gives a bunch of type errors (which I'm sure are
fixable, but using a Java map is simple and straightforward)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
