mjsax commented on code in PR #13179: URL: https://github.com/apache/kafka/pull/13179#discussion_r1097933056
########## streams/src/main/java/org/apache/kafka/streams/processor/StateRestoreListener.java: ########## @@ -37,6 +40,11 @@ * These two interfaces serve different restoration purposes and users should not try to implement both of them in a single * class during state store registration. * + * <p> + * Also note that standby tasks restoration process are not monitored via this interface, since a standby task keep Review Comment: > since a standby task keeps getting data from the changelogs written by the active stream tasks and hence would not complete restoration at all. -> `since a standby task does not actually _restore_ state (and updating a standby does never finish).` ########## streams/src/main/java/org/apache/kafka/streams/processor/StateRestoreListener.java: ########## @@ -37,6 +40,11 @@ * These two interfaces serve different restoration purposes and users should not try to implement both of them in a single * class during state store registration. * + * <p> + * Also note that standby tasks restoration process are not monitored via this interface, since a standby task keep Review Comment: > since a standby task keeps getting data from the changelogs written by the active stream tasks and hence would not complete restoration at all. -> `since a standby task does not actually _restore_ state (and updating a standby task does never finish).` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
