hgeraldino commented on PR #13191: URL: https://github.com/apache/kafka/pull/13191#issuecomment-1420146327
> Thanks @hgeraldino! > > I'm a little confused by the amount of churn here--it seems like a lot of utility methods related to topic creation, record transformation, etc. have been removed and their contents inlined directly into test cases. If this isn't necessary for the migration, can we try to retain that approach in order to reduce duplication? > > It's also worth noting that there are unused stubbings in some of these tests, which should be failing the build but are not at the moment due to [KAFKA-14682](https://issues.apache.org/jira/browse/KAFKA-14682). You can find these unused stubbings by running `./gradlew :connect:runtime:test --tests AbstractWorkerSourceTaskTest` in your command line, or possibly by running the entire `AbstractWorkerSourceTaskTest` test suite in IntelliJ (which is how I discovered them). These unused stubbings should be removed before we merge the PR. That's fair. Personally I prefer self-contained test methods hat can be read top-bottom (without having to jump around), even if it violates the DRY principle. But I'm ok on keeping the existing structure & style, so I put back the (revised) helper methods -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
