fvaleri commented on code in PR #13195: URL: https://github.com/apache/kafka/pull/13195#discussion_r1099975115
########## docs/upgrade.html: ########## @@ -19,6 +19,16 @@ <script id="upgrade-template" type="text/x-handlebars-template"> +<h4><a id="upgrade_3_5_0" href="#upgrade_3_5_0">Upgrading to 3.5.0 from any version 0.8.x through 3.4.x</a></h4> + + <h5><a id="upgrade_350_notable" href="#upgrade_350_notable">Notable changes in 3.5.0</a></h5> + <ul> + <li>The JmxTool has been migrated to the tools module. + As there is no wrapper script, users have to update their commands from "kafka-run-class.sh kafka.tools.JmxTool" to "kafka-run-class.sh org.apache.kafka.tools.JmxTool". Review Comment: > For the sake of considering all ideas, if we think renaming these classes is problematic, another option would be to have Java classes in the tools module that match the old Scala classes name and package. I also tried this. The problem with this idea is that checkstyle is only able to handle a single root package per module, so you end up with the following error. ```sh [ant:checkstyle] [ERROR] /home/fvaleri/Documents/kafka/tools/src/main/java/kafka/tools/JmxTool.java:17:1: Import control file does not handle this package. [ImportControl] ``` Possible alternatives: - create `:tools:deprecated` sub module containing `kafka.tools` root package with redirect classes (this works fine) - use reflection inside core module to redirect without depending on tools module (have to try this one) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
