fvaleri commented on PR #13158: URL: https://github.com/apache/kafka/pull/13158#issuecomment-1422555044
Hi @vamossagar12 this looks good, but I still think we should move `GetOffsetShellParsingTest` to `TopicPartitionFilterTest` removing any reference to `GetOffsetShell` (there is already a test for that) and create a new `PartitionFilterTest`, which should be similar to `TopicFilterTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
