jeffkbkim commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1100490932


##########
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java:
##########
@@ -212,24 +248,32 @@ public static ApiVersionCollection 
collectApis(Set<ApiKeys> apiKeys) {
      * @param listenerType the listener type which constrains the set of 
exposed APIs
      * @param minRecordVersion min inter broker magic
      * @param activeControllerApiVersions controller ApiVersions
+     * @param enableUnstableLastVersion whether unstable versions should be 
advertised or not

Review Comment:
   i'm a bit confused on the word "last". does this mean we enable only if the 
last version is unstable? my understanding is we enable all unstable versions 
or we don't



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to