jolshan commented on code in PR #13078:
URL: https://github.com/apache/kafka/pull/13078#discussion_r1104884018
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -264,6 +265,8 @@ class ReplicaManager(val config: KafkaConfig,
leaderPartitionsIterator.count(_.hasLateTransaction(currentTimeMs))
}
+ def producerIdCount: Int =
onlinePartitionsIterator.map(_.producerIdCount).sum
Review Comment:
Topic level metrics are a bit tricky because each broker may not host all
the partitions of a give topic. However, I suppose it could give a general idea
of tenant level usage. However, one concern is cardinality and the way that we
would aggregate and store these topic level metrics. KIP-847 also mentions the
rejected alternative of partition level metrics, but another concern there was
cardinality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
