jsancio commented on code in PR #13241:
URL: https://github.com/apache/kafka/pull/13241#discussion_r1105024172
##########
tools/src/main/java/org/apache/kafka/tools/MetadataQuorumCommand.java:
##########
@@ -116,6 +111,16 @@ static void execute(String... args) throws Exception {
}
}
+ private static Properties getProperties(File optionalCommandConfig) throws
TerseException, IOException {
+ if (optionalCommandConfig == null) {
+ return new Properties();
+ } else {
+ if (!optionalCommandConfig.exists())
+ throw new TerseException("Properties file " +
optionalCommandConfig.getPath() + " does not exists!");
Review Comment:
Minor but I would add a `{ }` block statement instead of using single line
statement for `if`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
