satishd commented on PR #13235: URL: https://github.com/apache/kafka/pull/13235#issuecomment-1429693785
Thanks @showuon for your review. > Overall LGTM! But do you think we should add a null `producerStateEntry` test case? Can you be more specific about the test case you are referring to here? If you are asking to write a test case to check for not containing a producer entry for active produces, those are already covered by using a check like `stateManager.activeProducers.containsKey(producerId)` instead of get and check for null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
