urbandan commented on PR #13163:
URL: https://github.com/apache/kafka/pull/13163#issuecomment-1429992202
@C0urante Existing tests (testWorkerConfigs and testClientConfigProperties)
already cover the config provider resolution (they use ${fake:secret:password}
and FakeConfigProvider), I don't think there is much else to add in this regard.
As an additional note, the explicit transformation in MirrorMakerConfig is
an unnecessary step, as both client (MirrorClientConfig) and worker configs
(DistributedConfig) get all the config provider configurations, and since those
classes extend AbstractConfig, they also perform the config resolution step.
Should we remove the explicit transform from MirrorMakerConfig?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
