dejan2609 commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1431575644
It seems that Spotless Gradle plugin needs to be alligned with Gradle 8.0 (I filed a ticket here: https://github.com/diffplug/spotless/issues/1572) Thing is that they dropped support for direct Java 8 builds: https://github.com/diffplug/spotless/blob/main/plugin-gradle/CHANGES.md#6140---2023-01-26 (their suggestion for other teams is to use Java cross compilation: https://docs.gradle.org/8.0/userguide/building_java_projects.html#sec:java_cross_compilation). Kafka obviously still needs to build artifacts against Java 8, so maybe it would be a good idea to use Spotless team suggestion. All-in-all, herewith a plan for a Gradle 7 -->> 8 upgrade: - spotless team will release Gradle 8.0 compatible version (most probably they will not backport solution into spotless gradle 6.13.x line) - in parallel I can try to drop JDK 8 usage (note: Java 8 compatible artifacts will still be generated) - when we make sure that Java cross compilation works we can come back to this PR and bump Gradle (and Spotless plugin version to 6.15+). @ijuma If it is ok with you I can start working towards this solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
