jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107785855
########## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponse.java: ########## @@ -99,6 +112,7 @@ public void maybeSetThrottleTimeMs(int throttleTimeMs) { data.setThrottleTimeMs(throttleTimeMs); } + // Only used for versions < 4 Review Comment: I guess if we want to deal with a map or larger data structure that has only one object we can. I think the tricky thing is knowing when we expect just one response how to use it correctly. That may require further refactoring but it is probably doable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org