philipnee commented on code in PR #13265:
URL: https://github.com/apache/kafka/pull/13265#discussion_r1109283896
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java:
##########
@@ -19,23 +19,35 @@
/**
* This is the abstract definition of the events created by the KafkaConsumer
API
*/
-abstract public class ApplicationEvent {
- public final Type type;
+public abstract class ApplicationEvent {
+
+ public enum Type {
+ NOOP,
+ ASSIGN_PARTITIONS,
+ COMMIT_ASYNC,
Review Comment:
I wonder if we need to treat async and sync commit differently. I think
they look the same from the background thread's prospective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
