satishd commented on code in PR #13255: URL: https://github.com/apache/kafka/pull/13255#discussion_r1109631097
########## storage/src/main/java/org/apache/kafka/storage/internals/log/RollParams.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.storage.internals.log; + +/** + * A class used to hold params required to decide to rotate a log segment or not. + */ +public class RollParams { + + public final long maxSegmentMs; + public final int maxSegmentBytes; + public final long maxTimestampInMessages; + public final long maxOffsetInMessages; + public final int messagesSize; + public final long now; + + public RollParams(long maxSegmentMs, + int maxSegmentBytes, + long maxTimestampInMessages, + long maxOffsetInMessages, + int messagesSize, + long now) { + + this.maxSegmentMs = maxSegmentMs; + this.maxSegmentBytes = maxSegmentBytes; + this.maxTimestampInMessages = maxTimestampInMessages; + this.maxOffsetInMessages = maxOffsetInMessages; + this.messagesSize = messagesSize; + this.now = now; + } + + public static RollParams create(LogConfig config, LogAppendInfo appendInfo, int messagesSize, long now) { Review Comment: May not be a good candidate for a constructor as it needs to build the fields from different other objects. But taking a relook at the usage, it is only called from UnifiedLog. I think we can use the existing constructor by passing the respective parameters from `UnifiedLog` and remove this factory method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
