jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1113435053
##########
clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json:
##########
@@ -23,17 +23,35 @@
// Version 2 adds the support for new error code PRODUCER_FENCED.
//
// Version 3 enables flexible versions.
- "validVersions": "0-3",
+ //
+ // Version 4 adds VerifyOnly field to check if partitions are already in
transaction and adds support to batch multiple transactions.
+ "validVersions": "0-4",
"flexibleVersions": "3+",
"fields": [
- { "name": "TransactionalId", "type": "string", "versions": "0+",
"entityType": "transactionalId",
+ { "name": "VerifyOnly", "type": "bool", "versions": "4+", "default": false,
Review Comment:
I'm wondering do we want to keep the top level verifyOnly as an
optimization? Or is it just more trouble than it's worth and maybe won't be
used too often.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
