dajac commented on code in PR #13295:
URL: https://github.com/apache/kafka/pull/13295#discussion_r1115722278
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -4208,6 +4208,77 @@ class KafkaApisTest {
assertEquals(expectedOffsetFetchResponse, response.data)
}
+ @ParameterizedTest
+ @ApiKeyVersionsSource(apiKey = ApiKeys.OFFSET_FETCH)
+ def testHandleOffsetFetchAllOffsetsWithSingleGroup(version: Short): Unit = {
+ // Version 0 gets offsets from Zookeeper. Version 1 does not support
fetching all
+ // offsets request. We are not interested in testing these here.
+ if (version < 2) return
+
+ def makeRequest(version: Short): RequestChannel.Request = {
+ buildRequest(new OffsetFetchRequest.Builder(
+ "group-1",
+ false,
+ null, // all offsets.
Review Comment:
This is the important bit. We need to test with `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
